Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update call fees docs on fallback #3471

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 29, 2023

the documented fallback was outdated.

this already mirrors geth's conversion which uses gasPrice 0 if no fields provided

@mattsse mattsse requested a review from Rjected as a code owner June 29, 2023 16:45
@mattsse mattsse requested a review from shekhirin June 29, 2023 16:45
@mattsse mattsse added the C-docs An addition or correction to our documentation label Jun 29, 2023
@mattsse mattsse requested a review from shekhirin June 29, 2023 16:54
mattsse and others added 2 commits June 29, 2023 18:55
@mattsse mattsse force-pushed the matt/docs-update-call-fees branch from db26581 to 181179c Compare June 29, 2023 16:55
@mattsse mattsse enabled auto-merge June 29, 2023 16:56
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3471 (181179c) into main (b0df026) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/revm_utils.rs 36.98% <100.00%> (+2.44%) ⬆️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.27% <33.33%> (+0.01%) ⬆️
unit-tests 64.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.01% <ø> (ø)
blockchain tree 81.69% <ø> (ø)
pipeline 87.88% <ø> (ø)
storage (db) 74.17% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 52.01% <ø> (ø)
networking 77.92% <ø> (+0.03%) ⬆️
rpc 58.14% <100.00%> (+0.07%) ⬆️
consensus 62.78% <ø> (ø)
revm 35.14% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.68% <ø> (+<0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit f9d9387 Jun 29, 2023
@mattsse mattsse deleted the matt/docs-update-call-fees branch June 29, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants