Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add total-transactions metric #3500

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 30, 2023

while this should always be the sum of all the other size fields, it's good to have so we can check that this is actually true.

@Rjected do we have these metrics on the dashboard?

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Jun 30, 2023
@mattsse mattsse requested a review from Rjected June 30, 2023 12:02
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3500 (a5547a2) into main (b225b47) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/transaction-pool/src/metrics.rs 100.00% <ø> (ø)
crates/transaction-pool/src/pool/txpool.rs 60.41% <0.00%> (-0.13%) ⬇️
crates/transaction-pool/src/traits.rs 5.26% <ø> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <0.00%> (+0.01%) ⬆️
unit-tests 64.24% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.05% <ø> (ø)
blockchain tree 81.69% <ø> (ø)
pipeline 87.88% <ø> (ø)
storage (db) 73.93% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 51.79% <0.00%> (+0.61%) ⬆️
networking 77.90% <ø> (ø)
rpc 58.13% <ø> (-0.01%) ⬇️
consensus 62.78% <ø> (ø)
revm 35.07% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.70% <ø> (+0.02%) ⬆️

@mattsse mattsse requested a review from rkrasiuk June 30, 2023 12:36
@mattsse mattsse added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit f08a863 Jun 30, 2023
@mattsse mattsse deleted the matt/add-total-transactions-metric branch June 30, 2023 13:40
@onbjerg onbjerg added the M-changelog This change should be included in the changelog label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants