Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm cached bytes gauge #3513

Merged
merged 1 commit into from
Jun 30, 2023
Merged

chore: rm cached bytes gauge #3513

merged 1 commit into from
Jun 30, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 30, 2023

as discovered, this is not very useful because most of the cached data is heap allocated

@mattsse mattsse requested a review from Rjected as a code owner June 30, 2023 18:08
@mattsse mattsse requested a review from rkrasiuk June 30, 2023 18:08
@mattsse mattsse added A-rpc Related to the RPC implementation A-observability Related to tracing, metrics, logs and other observability tools labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #3513 (bd2f3f4) into main (7e7f5e6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/cache.rs 67.47% <ø> (-0.12%) ⬇️

... and 4 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.28% <ø> (+0.01%) ⬆️
unit-tests 64.13% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.00% <ø> (ø)
blockchain tree 81.69% <ø> (ø)
pipeline 87.10% <ø> (ø)
storage (db) 73.93% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 51.14% <ø> (ø)
networking 77.89% <ø> (-0.07%) ⬇️
rpc 58.17% <ø> (-0.04%) ⬇️
consensus 62.78% <ø> (ø)
revm 35.07% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.70% <ø> (+0.02%) ⬆️

rkrasiuk
rkrasiuk approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, au revoir cached bytes metric. you did great job

@mattsse mattsse added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 7cb4a71 Jun 30, 2023
@mattsse mattsse deleted the matt/rm-cached-bytes-metrics branch June 30, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk