Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minimum docker engine version #3546

Merged
merged 2 commits into from
Jul 3, 2023
Merged

docs: minimum docker engine version #3546

merged 2 commits into from
Jul 3, 2023

Conversation

paolofacchinetti
Copy link
Contributor

@paolofacchinetti paolofacchinetti commented Jul 3, 2023

Add documentation regarding a minimum Docker Engine version.

Running Reth on an earlier version of Docker Engine causes a panic at startup due to a PermissionDenied error caused by the default Docker seccomp profile not supporting the clone3 syscall.

some more info:

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #3546 (79da606) into main (40f2a51) will decrease coverage by 0.35%.
The diff coverage is n/a.

❗ Current head 79da606 differs from pull request most recent head 3a0335f. Consider uploading reports for the commit 3a0335f to get more accurate results

Impacted file tree graph

see 82 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.24% <ø> (-0.03%) ⬇️
unit-tests 63.89% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.01% <ø> (+<0.01%) ⬆️
blockchain tree 81.25% <ø> (-0.44%) ⬇️
pipeline 86.98% <ø> (-0.91%) ⬇️
storage (db) 73.62% <ø> (-0.55%) ⬇️
trie 95.64% <ø> (+<0.01%) ⬆️
txpool 49.46% <ø> (-1.91%) ⬇️
networking 77.92% <ø> (-0.03%) ⬇️
rpc 57.89% <ø> (-0.25%) ⬇️
consensus 62.58% <ø> (-0.20%) ⬇️
revm 34.99% <ø> (-0.16%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 88.50% <ø> (-0.17%) ⬇️

@onbjerg onbjerg self-assigned this Jul 3, 2023
@onbjerg onbjerg added C-enhancement New feature or request A-meta Changes in the contributor workflow and planning labels Jul 3, 2023
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, ty for this, very informative

book/installation/docker.md Outdated Show resolved Hide resolved
@onbjerg onbjerg enabled auto-merge July 3, 2023 13:57
@onbjerg onbjerg added this pull request to the merge queue Jul 3, 2023
Merged via the queue into paradigmxyz:main with commit 7de2846 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants