Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: don't ignore examples #3570

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jul 4, 2023

I'm building the reth image with the following command:

docker build -t jsvisa/reth .

but failed with the following error:

Sending build context to Docker daemon  83.15MB
Step 1/21 : FROM lukemathwalker/cargo-chef:latest-rust-1 AS chef
 ---> 472d27704b24
Step 2/21 : WORKDIR /app
 ---> Using cache
 ---> fb0718f22efe
Step 3/21 : LABEL org.opencontainers.image.source=https://github.com/paradigmxyz/reth
 ---> Using cache
 ---> 475f992ba3e0
Step 4/21 : LABEL org.opencontainers.image.licenses="MIT OR Apache-2.0"
 ---> Using cache
 ---> 02be258ce0b8
Step 5/21 : FROM chef AS planner
 ---> 02be258ce0b8
Step 6/21 : COPY . .
 ---> 5f48eecab2ef
Step 7/21 : RUN cargo chef prepare --recipe-path recipe.json
 ---> Running in 32a40a260113
Error: Failed to compute recipe

Caused by:
    0: Cannot extract Cargo metadata
    1: `cargo metadata` exited with an error: error: failed to load manifest for workspace member `/app/examples`

       Caused by:
         failed to read `/app/examples/Cargo.toml`

       Caused by:
         No such file or directory (os error 2)

look forward for a while, found in cargo.toml we add examples, but which was ignored by ./dockerignore

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from gakonst as a code owner July 4, 2023 01:47
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3570 (2c5099d) into main (b4801f9) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

see 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.20% <ø> (-0.01%) ⬇️
unit-tests 63.90% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.01% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.98% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 49.46% <ø> (-0.63%) ⬇️
networking 77.87% <ø> (-0.03%) ⬇️
rpc 57.95% <ø> (-0.04%) ⬇️
consensus 62.58% <ø> (ø)
revm 34.95% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.28% <ø> (-0.02%) ⬇️

@rkrasiuk rkrasiuk added this pull request to the merge queue Jul 4, 2023
Merged via the queue into paradigmxyz:main with commit 9821311 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants