Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): txpool args #3575

Merged
merged 1 commit into from
Jul 4, 2023
Merged

feat(cli): txpool args #3575

merged 1 commit into from
Jul 4, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Jul 4, 2023

Description

Create TxPoolArgs to allow configuring transaction pool through CLI.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-cli Related to the reth CLI labels Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3575 (36e31f4) into main (4f32f56) will decrease coverage by 0.18%.
The diff coverage is 31.39%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/node/mod.rs 10.27% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/fees.rs 48.41% <0.00%> (ø)
crates/rpc/rpc/src/eth/pubsub.rs 7.38% <0.00%> (ø)
crates/storage/libmdbx-rs/src/cursor.rs 90.45% <ø> (ø)
crates/transaction-pool/src/lib.rs 36.00% <ø> (ø)
crates/transaction-pool/src/test_utils/mod.rs 100.00% <ø> (+5.55%) ⬆️
crates/transaction-pool/src/traits.rs 5.12% <0.00%> (-0.14%) ⬇️
crates/transaction-pool/src/noop.rs 11.38% <11.38%> (ø)
bin/reth/src/args/txpool_args.rs 20.51% <20.51%> (ø)
crates/blockchain-tree/src/blockchain_tree.rs 81.84% <50.00%> (ø)
... and 17 more

... and 31 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.19% <19.73%> (-0.05%) ⬇️
unit-tests 63.88% <25.11%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 22.99% <20.00%> (-0.03%) ⬇️
blockchain tree 81.25% <75.00%> (ø)
pipeline 86.98% <100.00%> (ø)
storage (db) 73.48% <95.23%> (-0.34%) ⬇️
trie 95.64% <100.00%> (ø)
txpool 49.51% <14.92%> (-1.64%) ⬇️
networking 77.88% <100.00%> (+0.01%) ⬆️
rpc 58.01% <72.22%> (+0.13%) ⬆️
consensus 62.58% <ø> (ø)
revm 34.95% <100.00%> (-0.05%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 88.26% <ø> (-0.25%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

using megabytes as unit is sufficient

needs followup for docs

@mattsse mattsse added the M-changelog This change should be included in the changelog label Jul 4, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 698059d Jul 4, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/cli-txpool-args branch July 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-tx-pool Related to the transaction mempool C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants