Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: book cli updater #3576

Merged
merged 14 commits into from
Jul 5, 2023
Merged

doc: book cli updater #3576

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
53c868b
doc: add script to update the book cli doc
leovct Jul 4, 2023
cbc05b3
ci: check if the book is up to date
leovct Jul 4, 2023
c2144b8
chore: replace `Users/**` path by `/Users/reth`
leovct Jul 4, 2023
5708a10
chore: update book doc
leovct Jul 4, 2023
91207db
nit: remove `Cargo.lock` update
leovct Jul 4, 2023
d0dd81b
nit: add newline at the end of `Cargo.lock`
leovct Jul 4, 2023
de87f21
ci: fix failing cmd
leovct Jul 5, 2023
1b9635c
ci: try to fix the issue
leovct Jul 5, 2023
792602d
ci: fix failing job
leovct Jul 5, 2023
983a179
ci: try with `./reth/target` path
leovct Jul 5, 2023
81ed25e
ci: try to fix failing jobs for the 115th time
leovct Jul 5, 2023
a0973ce
fix: default paths
leovct Jul 5, 2023
bb60e05
fix: wrong path - use `release` path instead of `debug`
leovct Jul 5, 2023
77d9f17
ci: remove job that checks if the book is up to date
leovct Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/book.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v3

- name: Try to update the book cli documentation
run: make update-book-cli
run: BUILD_PATH=/home/runner/work/reth/target && make update-book-cli
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use ./reth/target instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying rn 👍


- name: Check if the book cli documentation is up to date
run: |
Expand Down