-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cargo binstall support #3578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer to @onbjerg here
but if we do that, we should also mention this option in the README
Typically, it just works if the crate conforms to |
Updated book with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm
pending @onbjerg
Not sure that we want this? Seems like it adds more ways to install which seems redundant? |
|
As long as we don't have to do anything special for this to work, it's ok to add I guess. Imo cargo binstall is more for Rust utilities and Cargo plugins, so I don't see the big benefit here, but OTOH there isn't really a downside either (again, as long as we don't have to do anything special to make this work) |
@QEDK I accidentally fast merged it because I thought CI was tripping but I had to revert it. Please open up the PR again; this is not working because of your change to |
Adds binary installation support via
binstall
(https://github.com/cargo-bins/cargo-binstall).