Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config, primitives): validate Receipts prune part #3587

Merged
merged 3 commits into from
Jul 10, 2023
Merged

feat(config, primitives): validate Receipts prune part #3587

merged 3 commits into from
Jul 10, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jul 4, 2023 •
edited
Loading

Ref #3581

@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #3587 (d8dc2b7) into main (c236521) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/config/src/config.rs 64.10% <ø> (ø)
crates/primitives/src/serde_helper/mod.rs 73.68% <ø> (ø)
crates/primitives/src/serde_helper/prune.rs 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.08% <0.00%> (-0.05%) ⬇️
unit-tests 63.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (+<0.01%) ⬆️
trie 94.66% <ø> (-0.99%) ⬇️
txpool 49.11% <ø> (-0.40%) ⬇️
networking 77.94% <ø> (+0.03%) ⬆️
rpc 58.01% <ø> (+0.01%) ⬆️
consensus 62.10% <ø> (-0.49%) ⬇️
revm 34.90% <ø> (-0.05%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 88.33% <100.00%> (+0.06%) ⬆️

@shekhirin shekhirin marked this pull request as ready for review July 6, 2023 12:04
@shekhirin shekhirin requested a review from gakonst as a code owner July 6, 2023 12:04
mattsse
mattsse approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added the C-enhancement New feature or request label Jul 9, 2023
@shekhirin shekhirin added the A-pruning Related to pruning or full node label Jul 10, 2023
@shekhirin shekhirin added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 91dd782 Jul 10, 2023
@shekhirin shekhirin deleted the alexey/prune-config-receipts-validate branch July 10, 2023 11:56
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@shekhirin @merklefruit
feat(config, primitives): validate Receipts prune part (paradigmxyz#3587
bb20880 
)
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@shekhirin @merklefruit
feat(config, primitives): validate Receipts prune part (paradigmxyz#3587
72eb9a0 
)
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@shekhirin @merklefruit
feat(config, primitives): validate Receipts prune part (paradigmxyz#3587
d72793c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
A-pruning Related to pruning or full node C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shekhirin @mattsse @joshieDo @onbjerg