Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change field TransactionTrace order #3598

Merged
merged 1 commit into from
Jul 5, 2023
Merged

chore: change field TransactionTrace order #3598

merged 1 commit into from
Jul 5, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 5, 2023

use same order as other impls,
makes it easier to compare different outputs

@mattsse mattsse requested a review from Rjected as a code owner July 5, 2023 12:38
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Jul 5, 2023
@mattsse mattsse enabled auto-merge July 5, 2023 12:46
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #3598 (d058e51) into main (a932e2f) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc-types/src/eth/trace/parity.rs 2.70% <ø> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.12% <ø> (+0.01%) ⬆️
unit-tests 63.96% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.09% <ø> (ø)
txpool 49.20% <ø> (-0.62%) ⬇️
networking 77.88% <ø> (-0.04%) ⬇️
rpc 57.99% <ø> (-0.02%) ⬇️
consensus 62.69% <ø> (ø)
revm 34.95% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.27% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit 3806a0c Jul 5, 2023
@mattsse mattsse deleted the matt/change-trace-field-order branch July 5, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @onbjerg