Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(book): change recommended --authrpc.port value from 9999 to 8551 #3599

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

shekhirin
Copy link
Collaborator

We recommend to run Lighthouse with execution endpoint on port 8551 later, which is a bit confusing if people just follow the book:

reth/book/run/mainnet.md

Lines 49 to 54 in 3c292b4

```bash
RUST_LOG=info lighthouse bn \
--checkpoint-sync-url https://mainnet.checkpoint.sigp.io \
--execution-endpoint http://localhost:8551 \
--execution-jwt /path/to/secret
```

@shekhirin shekhirin marked this pull request as ready for review July 5, 2023 12:49
@shekhirin shekhirin requested a review from gakonst as a code owner July 5, 2023 12:49
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we should use default port here

@shekhirin shekhirin enabled auto-merge July 5, 2023 12:51
@rkrasiuk rkrasiuk added the C-docs An addition or correction to our documentation label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #3599 (3c292b4) into main (a932e2f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

see 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.11% <ø> (+<0.01%) ⬆️
unit-tests 64.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.09% <ø> (ø)
txpool 49.82% <ø> (ø)
networking 77.90% <ø> (-0.02%) ⬇️
rpc 58.01% <ø> (ø)
consensus 62.69% <ø> (ø)
revm 34.95% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.28% <ø> (-0.02%) ⬇️

@shekhirin shekhirin added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit 338d6d5 Jul 5, 2023
@shekhirin shekhirin deleted the alexey/docs-authrpc branch July 5, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants