Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error field to parity transaction traces #3611

Merged
merged 2 commits into from
Jul 6, 2023
Merged

feat: add error field to parity transaction traces #3611

merged 2 commits into from
Jul 6, 2023

Conversation

cjeva10
Copy link
Contributor

@cjeva10 cjeva10 commented Jul 5, 2023 •
edited by onbjerg
Loading

Closes #3600.

Removed TraceResult wrapper type and added explicit Error field to parity TransactionTrace.

@cjeva10 cjeva10 mentioned this pull request Jul 5, 2023
Closed
@onbjerg onbjerg changed the title Added error field to parity transaction traces. feat: add error field to parity transaction traces Jul 5, 2023
@onbjerg onbjerg added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jul 5, 2023
mattsse
mattsse approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

this is great, we now need to populate the error if the call failed in a followup

@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #3611 (71ebc3f) into main (428a6dc) will decrease coverage by 6.63%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/trace/parity.rs 3.22% <ø> (+0.52%) ⬆️
crates/rpc/rpc/src/trace.rs 43.84% <0.00%> (-0.10%) ⬇️

... and 119 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.10% <0.00%> (+0.01%) ⬆️
unit-tests 57.14% <0.00%> (-6.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 21.90% <ø> (-4.52%) ⬇️
blockchain tree 81.25% <ø> (ø)
pipeline 73.21% <ø> (-13.71%) ⬇️
storage (db) 67.17% <ø> (-6.32%) ⬇️
trie 88.02% <ø> (-6.64%) ⬇️
txpool 46.32% <ø> (-2.80%) ⬇️
networking 72.03% <ø> (-5.85%) ⬇️
rpc 52.51% <0.00%> (-5.54%) ⬇️
consensus 58.99% <ø> (-3.12%) ⬇️
revm 32.46% <0.00%> (-2.45%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 76.34% <ø> (-11.94%) ⬇️

@mattsse mattsse enabled auto-merge July 6, 2023 10:58
@mattsse mattsse mentioned this pull request Jul 6, 2023
Closed
@mattsse mattsse added this pull request to the merge queue Jul 6, 2023
Merged via the queue into paradigmxyz:main with commit 09fe22f Jul 6, 2023
@cjeva10 cjeva10 mentioned this pull request Jul 6, 2023
Merged
@mattsse mattsse mentioned this pull request Jul 6, 2023
Merged
@cjeva10 cjeva10 deleted the parity-trace-error-field branch July 20, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add error field to parity style TransactionTrace
3 participants
@cjeva10 @mattsse @onbjerg