pop duplicates entries when returning downloaded blocks in engine #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 202 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
added
C-perf
mattsse
requested changes
Jul 7, 2023
Comment on lines
308
to
314
| while let Some(peek) = self.range_buffered_blocks.peek() { | ||
| if peek.0 .0.hash() == block.0 .0.hash() { | ||
| self.range_buffered_blocks.pop(); | ||
| } else { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
please use peek_mut
besides that, this is exactly what we want
mattsse
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3629