Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a few noop functions to builder #3659

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 7, 2023

add a few convenience functions to the builder to make it easier to configure rpc without certain components

@mattsse mattsse requested a review from Rjected as a code owner July 7, 2023 14:31
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #3659 (a47efa9) into main (526f624) will decrease coverage by 28.85%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc-builder/src/lib.rs 54.26% <0.00%> (-13.37%) ⬇️

... and 278 files with indirect coverage changes

Flag Coverage Δ
integration-tests 13.56% <0.00%> (-2.36%) ⬇️
unit-tests 34.01% <0.00%> (-30.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 10.76% <ø> (-15.64%) ⬇️
blockchain tree 69.93% <ø> (-11.33%) ⬇️
pipeline 49.76% <ø> (-36.94%) ⬇️
storage (db) 53.03% <ø> (-20.46%) ⬇️
trie 58.94% <ø> (-35.73%) ⬇️
txpool 30.41% <ø> (-18.88%) ⬇️
networking 40.55% <ø> (-37.29%) ⬇️
rpc 31.27% <0.00%> (-26.95%) ⬇️
consensus 36.70% <ø> (-26.66%) ⬇️
revm 18.39% <ø> (-16.47%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 48.52% <ø> (-39.76%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@mattsse mattsse enabled auto-merge July 7, 2023 15:55
@mattsse mattsse added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit a7f32db Jul 7, 2023
@mattsse mattsse deleted the matt/extend-builder branch July 7, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants