Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use units on dashboard #3684

Merged
merged 1 commit into from
Jul 9, 2023
Merged

chore: use units on dashboard #3684

merged 1 commit into from
Jul 9, 2023

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jul 9, 2023

Some adjustments to the dashboard

  • The graphs that used to say (bytes) now use the bytes unit instead (buffer sizes, tx pool size, ...)
  • The error graphs now plot cps (errors/s)
  • Two graphs utilize inverted y-axis to visualize two opposing operations (insert/remove, tx/rx). The "Network transaction channel" graph wasn't really clear to me since it just plotted 0, -1 or +1 for me all the time. See example below of these two graphs

image

@onbjerg onbjerg added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools labels Jul 9, 2023
@onbjerg onbjerg requested a review from gakonst as a code owner July 9, 2023 17:07
@onbjerg onbjerg enabled auto-merge July 9, 2023 17:11
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #3684 (04aae2c) into main (f116040) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

see 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.91% <ø> (+<0.01%) ⬆️
unit-tests 64.09% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.35% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.69% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 94.66% <ø> (ø)
txpool 49.34% <ø> (-0.61%) ⬇️
networking 77.81% <ø> (-0.02%) ⬇️
rpc 58.09% <ø> (ø)
consensus 63.35% <ø> (ø)
revm 34.86% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.24% <ø> (-0.01%) ⬇️

@onbjerg onbjerg added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit f201176 Jul 9, 2023
@onbjerg onbjerg deleted the onbjerg/dashboard-units branch July 9, 2023 18:13
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants