Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix engine hive of Invalid Transition Payload Sync #3710

Merged
merged 1 commit into from
Jul 11, 2023
Merged

test: fix engine hive of Invalid Transition Payload Sync #3710

merged 1 commit into from
Jul 11, 2023

Conversation

int88
Copy link
Contributor

@int88 int88 commented Jul 11, 2023

fixes: #2839

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #3710 (8a4a437) into main (467f6f9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 75.49% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.88% <ø> (+<0.01%) ⬆️
unit-tests 64.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.35% <ø> (ø)
blockchain tree 81.58% <ø> (ø)
pipeline 86.75% <ø> (ø)
storage (db) 73.51% <ø> (ø)
trie 94.66% <ø> (ø)
txpool 49.59% <ø> (ø)
networking 77.87% <ø> (+0.03%) ⬆️
rpc 58.24% <ø> (+0.01%) ⬆️
consensus 63.40% <ø> (ø)
revm 34.86% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.28% <ø> (ø)

@int88
Copy link
Contributor Author

int88 commented Jul 11, 2023

@mattsse @Rjected PTAL

Rjected
Rjected approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but have not run in hive yet

crates/consensus/beacon/src/engine/mod.rs
@@ -849,8 +849,15 @@ where
let block_hash = block.hash();
let block_num_hash = block.num_hash();

let mut lowest_buffered_ancestor = self.lowest_buffered_ancestor_or(block.hash);
Copy link
Member

@Rjected Rjected Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, we only want to check a buffered ancestor if there is one, otherwise use the parent

@Rjected
Copy link
Member

Rjected commented Jul 11, 2023 •
edited
Loading

Nice, thank you!

INFO[07-11|15:11:02] hiveproxy started                        container=7c3860f72465 addr=172.17.0.2:8081
INFO[07-11|15:11:02] API: suite started                       suite=0 name=engine-api
INFO[07-11|15:11:02] API: test started                        suite=0 test=1 name="Invalid Transition Payload Sync, Invalid GasLimit (reth)"
INFO[07-11|15:11:03] API: client reth started                 suite=0 test=1 container=ea1f9dcb
INFO[07-11|15:11:09] API: container IP requested              network=bridge container=ea1f9dcb ip=172.17.0.4
INFO[07-11|15:11:12] API: test ended                          suite=0 test=1 pass=true
INFO[07-11|15:11:12] API: suite ended                         suite=0
INFO[07-11|15:11:12] simulation ethereum/engine finished      suites=1 tests=1 failed=0

@Rjected Rjected added this pull request to the merge queue Jul 11, 2023
Merged via the queue into paradigmxyz:main with commit 7fa032f Jul 11, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@int88 @merklefruit
test: fix engine hive of Invalid Transition Payload Sync (paradigmx…
8eed944 
…yz#3710)
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@int88 @merklefruit
test: fix engine hive of Invalid Transition Payload Sync (paradigmx…
3c02b30 
…yz#3710)
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@int88 @merklefruit
test: fix engine hive of Invalid Transition Payload Sync (paradigmx…
d09a3fc 
…yz#3710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

engine hive: Invalid Transition Payload Sync
2 participants
@int88 @Rjected