Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3667 Add Dial Success Metric #3729

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

maxwolff
Copy link
Contributor

adds a metric for how many outgoing dials resulted in an active session
closes issue

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #3729 (20e8064) into main (a7f32db) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/net/network/src/metrics.rs 61.53% <100.00%> (+3.20%) ⬆️
crates/net/network/src/session/mod.rs 76.17% <100.00%> (+0.31%) ⬆️

... and 72 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.78% <100.00%> (-0.13%) ⬇️
unit-tests 64.32% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.28% <ø> (-0.12%) ⬇️
blockchain tree 83.03% <ø> (+1.78%) ⬆️
pipeline 87.12% <ø> (+0.42%) ⬆️
storage (db) 74.21% <ø> (+0.72%) ⬆️
trie 94.66% <ø> (ø)
txpool 48.78% <ø> (-0.51%) ⬇️
networking 77.83% <100.00%> (+<0.01%) ⬆️
rpc 58.50% <ø> (+0.35%) ⬆️
consensus 64.90% <ø> (+1.54%) ⬆️
revm 33.85% <ø> (-1.02%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 88.37% <ø> (+0.12%) ⬆️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supportive,

style nit

crates/net/network/src/session/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can also add this to the dashboard

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Jul 12, 2023
@mattsse mattsse added this pull request to the merge queue Jul 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 12, 2023
@mattsse mattsse added this pull request to the merge queue Jul 12, 2023
Merged via the queue into paradigmxyz:main with commit f6646aa Jul 12, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total peer additions metric
2 participants