-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable jemalloc by default on unix #3735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want this.
pending @rkrasiuk
Codecov Report
... and 161 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would simplify the makefile too by removing the feature filtering/special handling for windows etc around jemalloc
b4f577c
to
5131dbb
Compare
d76e3e7
to
983f1e3
Compare
This PR additionally gates jemallocator usage by
unix
target family and enablesjemalloc
feature by default. It means the following:--no-default-features
.--features jemalloc
is specified, ignore it because Windows is not fully supported by jemalloc.Windows builds successfully: https://github.com/paradigmxyz/reth/actions/runs/5543015346/jobs/10118463541?pr=3735