Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable jemalloc by default on unix #3735

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jul 12, 2023

This PR additionally gates jemallocator usage by unix target family and enables jemalloc feature by default. It means the following:

  1. On Unix, use jemallocator if not specified otherwise via --no-default-features .
  2. On Windows, use default allocator. If --features jemalloc is specified, ignore it because Windows is not fully supported by jemalloc.

Windows builds successfully: https://github.com/paradigmxyz/reth/actions/runs/5543015346/jobs/10118463541?pr=3735

@shekhirin shekhirin changed the title chore: enable jemalloc by default on non-windows OS chore: enable jemalloc by default on unix Jul 12, 2023
@shekhirin shekhirin marked this pull request as ready for review July 12, 2023 16:09
@shekhirin shekhirin requested a review from onbjerg as a code owner July 12, 2023 16:09
@shekhirin shekhirin requested a review from gakonst July 12, 2023 16:09
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this.

pending @rkrasiuk

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #3735 (785a8a7) into main (e3ac77a) will decrease coverage by 9.86%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/main.rs 14.28% <ø> (ø)
bin/reth/src/prometheus_exporter.rs 0.00% <ø> (ø)

... and 161 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.78% <ø> (-0.01%) ⬇️
unit-tests 43.90% <ø> (-10.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 17.67% <ø> (-7.07%) ⬇️
blockchain tree 31.90% <ø> (-9.83%) ⬇️
pipeline 66.86% <ø> (-12.38%) ⬇️
storage (db) 52.49% <ø> (-6.68%) ⬇️
trie 58.76% <ø> (-12.83%) ⬇️
txpool 35.60% <ø> (-8.48%) ⬇️
networking 56.84% <ø> (-11.76%) ⬇️
rpc 44.60% <ø> (-6.82%) ⬇️
consensus 42.73% <ø> (-14.07%) ⬇️
revm 21.22% <ø> (-7.47%) ⬇️
payload builder 6.61% <ø> (ø)
primitives 65.30% <ø> (-13.03%) ⬇️

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would simplify the makefile too by removing the feature filtering/special handling for windows etc around jemalloc

@shekhirin shekhirin marked this pull request as draft July 12, 2023 17:16
@shekhirin shekhirin added the C-perf A change motivated by improving speed, memory usage or disk footprint label Jul 12, 2023
@shekhirin shekhirin marked this pull request as ready for review July 13, 2023 12:51
@shekhirin shekhirin requested a review from rkrasiuk July 14, 2023 11:28
@shekhirin shekhirin added this pull request to the merge queue Jul 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@shekhirin shekhirin added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit c0cafc7 Jul 14, 2023
@shekhirin shekhirin deleted the alexey/jemalloc-default branch July 14, 2023 18:56
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants