feat: txpool block building fallback #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-enhancement
Codecov Report
... and 167 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gakonst
approved these changes
Jul 15, 2023
Comment on lines
+130
to
+132
| } else { | ||
| self.local_pending_block().await | ||
| } |
Comment on lines
+271
to
+272
| // TODO(mattsse): actually build the pending block | ||
| Ok(None) |
Comment on lines
+253
to
+254
| // no pending block from the CL yet, so we need to build it ourselves via txpool | ||
| self.on_blocking_task(|this| async move { |
There was a problem hiding this comment.
Makes me think we should probably add docs on which ops are blocking and when we recommend spawning blocking?
There was a problem hiding this comment.
good point, will do!
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 18, 2023
merklefruit
pushed a commit
to merklefruit/op-reth-old
that referenced
this pull request
Jul 26, 2023
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prep for #3702
this prepares for local block building for pending block if no block from CL is available yet.
the actually impl will be in a followup because I need to refactor/reuse some stuff from the basic payload builder impl