Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorder call action fields #3758

Merged
merged 2 commits into from
Jul 13, 2023
Merged

chore: reorder call action fields #3758

merged 2 commits into from
Jul 13, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 13, 2023

reorder fields to match other impls, makes comparing output easier

@mattsse mattsse requested a review from Rjected as a code owner July 13, 2023 13:30
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #3758 (f235120) into main (8bfc3d0) will decrease coverage by 5.30%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc-types/src/eth/trace/parity.rs 66.31% <ø> (ø)

... and 281 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.76% <ø> (?)
unit-tests 54.17% <ø> (-10.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 24.74% <ø> (-1.55%) ⬇️
blockchain tree 41.72% <ø> (-41.31%) ⬇️
pipeline 79.24% <ø> (-7.88%) ⬇️
storage (db) 59.13% <ø> (-10.54%) ⬇️
trie 71.59% <ø> (-23.07%) ⬇️
txpool 44.07% <ø> (-5.31%) ⬇️
networking 68.58% <ø> (-4.13%) ⬇️
rpc 51.35% <ø> (+10.87%) ⬆️
consensus 56.67% <ø> (-8.15%) ⬇️
revm 28.72% <ø> (-4.32%) ⬇️
payload builder 6.61% <ø> (+2.25%) ⬆️
primitives 78.35% <ø> (-8.59%) ⬇️

@mattsse mattsse enabled auto-merge July 13, 2023 14:40
@mattsse mattsse added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit f3e13db Jul 13, 2023
@mattsse mattsse deleted the matt/reorder-fields branch July 13, 2023 15:52
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants