fix: poll logic when pipeline active #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-bug
gakonst
reviewed
Jul 13, 2023
|
need to familiarize myself with tokio console features first, if it's possible to monitor certain tasks and their state |
Codecov Report
... and 183 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
cc @jonasbostoen as i saw you using tokio-console before, in case any input |
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 18, 2023
merklefruit
pushed a commit
to merklefruit/op-reth-old
that referenced
this pull request
Jul 26, 2023
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3754
the prune changes broke the poll logic when the pipeline is active
#3566
in which case we were returning pending even if there still is work to do (available engine messages for example)