Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing null check #3766

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: add missing null check #3766

merged 1 commit into from
Jul 14, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 13, 2023

closes #3765

missing json null check when extracting configs.

all config values are optional

@mattsse mattsse requested a review from Rjected as a code owner July 13, 2023 21:53
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Jul 13, 2023
@mattsse mattsse force-pushed the matt/fix-missing-null-check branch from 9c4166f to 6fc30d4 Compare July 13, 2023 21:58
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #3766 (6fc30d4) into main (ac12cc4) will decrease coverage by 11.61%.
The diff coverage is 88.23%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/rpc/rpc-types/src/eth/trace/geth/mod.rs 68.75% <88.23%> (+1.18%) ⬆️

... and 192 files with indirect coverage changes

Flag Coverage Δ
integration-tests 12.69% <0.00%> (-3.07%) ⬇️
unit-tests 54.20% <88.23%> (-10.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 24.74% <ø> (-1.42%) ⬇️
blockchain tree 41.72% <ø> (-41.30%) ⬇️
pipeline 79.24% <ø> (-7.90%) ⬇️
storage (db) 58.17% <ø> (-16.03%) ⬇️
trie 71.59% <ø> (-23.07%) ⬇️
txpool 44.07% <ø> (-5.30%) ⬇️
networking 68.06% <ø> (-9.67%) ⬇️
rpc 42.23% <88.23%> (-16.25%) ⬇️
consensus 56.74% <ø> (-8.23%) ⬇️
revm 27.90% <ø> (-5.90%) ⬇️
payload builder 4.13% <ø> (-2.49%) ⬇️
primitives 77.87% <ø> (-10.49%) ⬇️

@mattsse mattsse requested a review from rkrasiuk July 14, 2023 09:45
@mattsse mattsse added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 3b16a6b Jul 14, 2023
@mattsse mattsse deleted the matt/fix-missing-null-check branch July 14, 2023 12:09
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"invalid tracer config" when requesting debug_traceTransaction with callTracer
2 participants