Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trim cmd args in parser #3789

Merged
merged 1 commit into from
Jul 15, 2023
Merged

feat: trim cmd args in parser #3789

merged 1 commit into from
Jul 15, 2023

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Jul 15, 2023 •
edited
Loading

Trims the cmd options in the parser
Closes #3769

mattsse
mattsse approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ty

@mattsse mattsse marked this pull request as ready for review July 15, 2023 09:32
@mattsse mattsse added A-rpc Related to the RPC implementation A-cli Related to the reth CLI labels Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #3789 (b9d7528) into main (c1b1eac) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/args/rpc_server_args.rs 50.13% <100.00%> (+2.51%) ⬆️
crates/rpc/rpc-builder/src/lib.rs 66.28% <100.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.77% <0.00%> (+<0.01%) ⬆️
unit-tests 64.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.33% <100.00%> (+0.28%) ⬆️
blockchain tree 83.02% <ø> (ø)
pipeline 87.13% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.65% <ø> (ø)
txpool 49.37% <ø> (+0.60%) ⬆️
networking 77.63% <ø> (-0.05%) ⬇️
rpc 58.56% <100.00%> (ø)
consensus 64.96% <ø> (ø)
revm 33.76% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.30% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 15, 2023
Merged via the queue into paradigmxyz:main with commit be656c2 Jul 15, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 18, 2023
@PanGan21 @merklefruit
feat: trim cmd args in parser (paradigmxyz#3789)
48e51b8
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
@PanGan21 @merklefruit
feat: trim cmd args in parser (paradigmxyz#3789)
d3ced8b
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
@PanGan21 @merklefruit
feat: trim cmd args in parser (paradigmxyz#3789)
ecfc962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd option parse error when start node with multi rpc namespace
3 participants
@PanGan21 @onbjerg @mattsse