fix: concurrent ipc driver impl #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-perf
mattsse
force-pushed
the
matt/concurrent-ipc-driver
branch
from
9c4a5b8
to
d80e730
Compare
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gakonst
approved these changes
Jul 15, 2023
| } | ||
| } | ||
|
|
||
| impl<T, S> Future for IpcConnDriver<T, S, S::Future> |
There was a problem hiding this comment.
I've seen you write this pattern so many times at this point...do we have any great blogpost which explains this? would be valuable to point contributors towards
There was a problem hiding this comment.
do we have any great blogpost
not really, it is mostly dependent on the specific use case, and how the data flows here
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 18, 2023
merklefruit
pushed a commit
to merklefruit/op-reth-old
that referenced
this pull request
Jul 26, 2023
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3784
handle reads, calls and writes concurrently