Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use 50M default gas limit for calls in rpc #3812

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 17, 2023

use configured gas cap for calls

@mattsse mattsse requested a review from shekhirin July 17, 2023 15:22
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 17, 2023
@joshieDo
Copy link
Collaborator

joshieDo commented Jul 17, 2023

lgtm, but given the arbitrary origin of this value... would this be a configurable value instead be of interest? (by the operator)

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 17, 2023

lgtm, but given the arbitrary origin of this value... could this be a configurable value instead?

it is since #3458

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #3812 (a93c2c1) into main (eb32fd3) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/args/rpc_server_args.rs 51.53% <ø> (ø)
crates/rpc/rpc/src/debug.rs 10.88% <0.00%> (-0.18%) ⬇️
crates/rpc/rpc/src/eth/api/mod.rs 64.94% <0.00%> (ø)
crates/rpc/rpc/src/trace.rs 43.86% <50.00%> (+0.02%) ⬆️
crates/rpc/rpc/src/eth/api/transactions.rs 27.68% <71.42%> (+0.51%) ⬆️
crates/rpc/rpc-builder/src/eth.rs 70.96% <100.00%> (ø)
crates/rpc/rpc/src/eth/revm_utils.rs 36.52% <100.00%> (+0.18%) ⬆️

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.63% <42.85%> (-0.01%) ⬇️
unit-tests 64.16% <4.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.49% <ø> (ø)
blockchain tree 83.02% <ø> (ø)
pipeline 87.04% <ø> (ø)
storage (db) 74.32% <ø> (ø)
trie 94.65% <ø> (ø)
txpool 46.85% <ø> (ø)
networking 77.57% <ø> (+0.03%) ⬆️
rpc 58.91% <42.85%> (-0.03%) ⬇️
consensus 64.96% <ø> (ø)
revm 33.76% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.04% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 01e1344 Jul 17, 2023
@mattsse mattsse deleted the matt/use-50M-gaslimit branch July 17, 2023 17:08
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
merklefruit pushed a commit to anton-rs/op-reth that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants