Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): support both input and data fields #3911

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 25, 2023

@mattsse mattsse requested a review from Rjected as a code owner July 25, 2023 15:50
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #3911 (f38c34f) into main (af60428) will decrease coverage by 0.04%.
The diff coverage is 62.22%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/api/transactions.rs 27.68% <0.00%> (ø)
crates/rpc/rpc/src/eth/error.rs 10.00% <0.00%> (-0.06%) ⬇️
crates/rpc/rpc-types/src/eth/call.rs 64.00% <63.41%> (-2.67%) ⬇️
crates/rpc/rpc/src/eth/revm_utils.rs 36.52% <100.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.50% <17.77%> (-0.02%) ⬇️
unit-tests 64.45% <55.55%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.24% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.66% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (-0.57%) ⬇️
networking 77.60% <ø> (-0.04%) ⬇️
rpc 58.38% <62.22%> (+0.01%) ⬆️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.05% <ø> (ø)

@onbjerg onbjerg added the C-bug An unexpected or incorrect behavior label Jul 25, 2023
@onbjerg onbjerg added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 4a24ae2 Jul 25, 2023
@onbjerg onbjerg deleted the matt/support-input-and-data branch July 25, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when sending duplicate "Data" and "Input" Fields
2 participants