Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: _V3 engine api skeletons #3931

Merged
merged 2 commits into from
Jul 26, 2023
Merged

feat: _V3 engine api skeletons #3931

merged 2 commits into from
Jul 26, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 26, 2023

ref #2893

not announced via caps yet, but adds the definitions

@mattsse mattsse requested a review from Rjected as a code owner July 26, 2023 15:15
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3931 (2f3892e) into main (caa2683) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-api/src/engine.rs 50.00% <ø> (ø)
crates/rpc/rpc-engine-api/src/engine_api.rs 87.66% <0.00%> (-2.22%) ⬇️
crates/rpc/rpc-types/src/eth/engine/payload.rs 88.91% <0.00%> (-0.25%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <0.00%> (-0.04%) ⬇️
unit-tests 64.45% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.24% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.68% <ø> (ø)
storage (db) 74.19% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (ø)
networking 77.68% <ø> (+0.07%) ⬆️
rpc 58.50% <0.00%> (-0.08%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.06% <ø> (ø)

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering about beaconBlockRoot, I think we'll also need followups to add some of the new fields to other engine types

Comment on lines 29 to 30
versioned_hashes: Vec<H256>,
) -> RpcResult<PayloadStatus>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[method(name = "newPayloadV3")]
async fn new_payload_v3(
&self,
payload: ExecutionPayload,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to modify ExecutionPayload to include dataGasUsed and excessGasUsed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do this after we have this added to the header as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 26, 2023

added missing arg

just realized there's a cancun readme, but will do the remaining functions separately

@onbjerg onbjerg added the C-enhancement New feature or request label Jul 26, 2023
@onbjerg onbjerg added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 96b108f Jul 26, 2023
@onbjerg onbjerg deleted the matt/declare-some-v3-handlers branch July 26, 2023 16:51
@rkrasiuk rkrasiuk added the E-cancun Related to the Cancun network upgrade label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request E-cancun Related to the Cancun network upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants