Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test(ethereum): ignore invalid string sequence in ethereum state tests (#3307)" #3937

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Revert "test(ethereum): ignore invalid string sequence in ethereum state tests (#3307)" #3937

merged 1 commit into from
Jul 26, 2023

Conversation

shekhirin
Copy link
Collaborator

This reverts commit 7b77fc1.

No need anymore, EF tests were fixed in ethereum/tests#1231 and this sequence doesn't appear anymore (see e.g. ethereum/tests@06e2767).

@shekhirin shekhirin marked this pull request as ready for review July 26, 2023 17:45
@shekhirin shekhirin requested a review from gakonst as a code owner July 26, 2023 17:45
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 26, 2023
@shekhirin shekhirin enabled auto-merge July 26, 2023 17:46
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #3937 (aca2596) into main (a71ad1e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

see 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.57% <ø> (-0.02%) ⬇️
unit-tests 64.51% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.18% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.79% <ø> (ø)
storage (db) 74.28% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (-0.60%) ⬇️
networking 77.61% <ø> (-0.10%) ⬇️
rpc 58.86% <ø> (ø)
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.93% <ø> (ø)

@shekhirin shekhirin added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 9adab0b Jul 26, 2023
@shekhirin shekhirin deleted the alexey/revert-ef-tests-hack branch July 26, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse