Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rpc): move frame gen into task #3950

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 27, 2023

does not need to be performed in the rpc context and should be performed in the task

@mattsse mattsse requested a review from Rjected as a code owner July 27, 2023 10:34
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3950 (55c086c) into main (0147e50) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/debug.rs 11.77% <0.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.56% <0.00%> (+0.03%) ⬆️
unit-tests 64.55% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.18% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.29% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.56% <ø> (-0.03%) ⬇️
networking 77.69% <ø> (+0.03%) ⬆️
rpc 58.75% <0.00%> (ø)
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.80% <ø> (-0.03%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit f3a7ae1 Jul 27, 2023
@Rjected Rjected deleted the matt/perf-move-fram-gen-into-task branch July 27, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants