Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(p2p): Add GetReceipts eth handler implementation #3959

Merged
merged 5 commits into from
Jul 31, 2023
Merged

feat(p2p): Add GetReceipts eth handler implementation #3959

merged 5 commits into from
Jul 31, 2023

Conversation

tcoratger
Copy link
Contributor

Should solve #3956.

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #3959 (3613f8b) into main (f98b152) will decrease coverage by 0.12%.
Report is 8 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/network/src/eth_requests.rs 57.77% <0.00%> (-17.96%) ⬇️

... and 25 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <0.00%> (-0.06%) ⬇️
unit-tests 64.43% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <ø> (-0.02%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (+0.01%) ⬆️
trie 94.70% <ø> (ø)
txpool 45.18% <ø> (-0.82%) ⬇️
networking 77.49% <0.00%> (-0.21%) ⬇️
rpc 58.75% <ø> (+<0.01%) ⬆️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.81% <ø> (-0.10%) ⬇️

@tcoratger tcoratger marked this pull request as ready for review July 27, 2023 14:18
@mattsse mattsse linked an issue Jul 27, 2023 that may be closed by this pull request
Add getreceipts eth handler implementation #3956
Closed
@mattsse mattsse added the A-networking Related to networking in general label Jul 27, 2023
mattsse
mattsse requested changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for all of these 🙏

crates/net/network/src/eth_requests.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg changed the title feat(primitives): Add GetReceipts eth handler implementation feat(p2p): Add GetReceipts eth handler implementation Jul 31, 2023
@onbjerg onbjerg added C-enhancement New feature or request A-devp2p Related to the Ethereum P2P protocol M-changelog This change should be included in the changelog labels Jul 31, 2023
@onbjerg onbjerg enabled auto-merge July 31, 2023 12:55
@onbjerg onbjerg added this pull request to the merge queue Jul 31, 2023
mattsse
mattsse approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
we'll move to raw impls for this, but for now this is great

Merged via the queue into paradigmxyz:main with commit c0544ed Jul 31, 2023
@tcoratger tcoratger deleted the getreceipts branch August 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol A-networking Related to networking in general C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getreceipts eth handler implementation
3 participants
@tcoratger @onbjerg @mattsse