Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): eta div by zero #3971

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix(cli): eta div by zero #3971

merged 2 commits into from
Jul 27, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Jul 27, 2023 •
edited
Loading

Description

Fix possible division by zero in eta calculation.

Screenshot_2023-07-27_at_19 49 05

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Jul 27, 2023
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner July 27, 2023 17:01
@rkrasiuk rkrasiuk requested a review from mattsse July 27, 2023 17:01
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #3971 (3e23a7c) into main (a298756) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/node/events.rs 12.88% <0.00%> (-0.07%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <0.00%> (-0.03%) ⬇️
unit-tests 64.46% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <0.00%> (-0.01%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.18% <ø> (-0.59%) ⬇️
networking 77.63% <ø> (-0.09%) ⬇️
rpc 58.75% <ø> (ø)
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.82% <ø> (+0.02%) ⬆️

mattsse
mattsse requested changes Jul 27, 2023
View reviewed changes
bin/reth/src/node/events.rs Outdated Show resolved Hide resolved
@mattsse mattsse added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 465f0dc Jul 27, 2023
@mattsse mattsse deleted the rkrasiuk/fix-div-by-zero branch July 27, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @mattsse @joshieDo