Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(txpool): export validation constants #3979

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore(txpool): export validation constants #3979

merged 1 commit into from
Jul 28, 2023

Conversation

rkrasiuk
Copy link
Member

Motivation

Re-export validation constants for external use.

@rkrasiuk rkrasiuk added the A-tx-pool Related to the transaction mempool label Jul 28, 2023
@rkrasiuk rkrasiuk requested a review from mattsse as a code owner July 28, 2023 10:50
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #3979 (9710683) into main (d2cdd10) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/lib.rs 32.31% <ø> (ø)
crates/transaction-pool/src/validate/eth.rs 0.00% <ø> (ø)
crates/transaction-pool/src/validate/mod.rs 43.03% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.37% <ø> (-0.02%) ⬇️
unit-tests 64.43% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.58% <ø> (ø)
networking 77.62% <ø> (-0.04%) ⬇️
rpc 58.44% <ø> (-0.01%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.82% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit c33f930 Jul 28, 2023
@mattsse mattsse deleted the rkrasiuk/chore-txpool-constants branch July 28, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse