-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracing): extend Parity tracing VmExecutedOperation #3997
fix(tracing): extend Parity tracing VmExecutedOperation #3997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, tysm for taking this on.
what's missing?
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Ok, adding the |
@pistomat If it's work for another time, would you mind creating a new issue for that with a description of what is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Convert VmExecutedOperation::push from Option<> to Vec<> as per ethers-rs and erigon implementation
Closes #3883