Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile): Graceful cargo-nextest install #4009

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jul 31, 2023

Addresses #4008.

This PR is a very simple addition to the Makefile to install the cargo-nextest bin prior to executing unit tests with cargo nextest ...

@refcell refcell requested a review from gakonst as a code owner July 31, 2023 17:46
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will display a message if already installed,

I think we can live with that, wdyt @onbjerg ?

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #4009 (8e95e19) into main (dee14c7) will decrease coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.23% <ø> (-0.03%) ⬇️
unit-tests 64.14% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.63% <ø> (-0.07%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (-0.61%) ⬇️
networking 77.49% <ø> (-0.03%) ⬇️
rpc 58.37% <ø> (+0.01%) ⬆️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.04% <ø> (-0.02%) ⬇️

@rkrasiuk rkrasiuk added the A-meta Changes in the contributor workflow and planning label Aug 1, 2023
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supportive, pending @onbjerg

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay

@onbjerg onbjerg added this pull request to the merge queue Aug 9, 2023
Merged via the queue into paradigmxyz:main with commit 4de1ff0 Aug 9, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants