Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add subkey docs to StorageEntry #4016

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 1, 2023

Added these docs as I've been going through more of the database and trie code

@Rjected Rjected added C-docs An addition or correction to our documentation A-db Related to the database labels Aug 1, 2023
@Rjected Rjected requested a review from joshieDo August 1, 2023 00:30
@Rjected Rjected requested a review from gakonst as a code owner August 1, 2023 00:30
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #4016 (0e3be3c) into main (27c65d2) will decrease coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/storage.rs 100.00% <ø> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.23% <ø> (+<0.01%) ⬆️
unit-tests 64.14% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.63% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (ø)
networking 77.50% <ø> (-0.15%) ⬇️
rpc 58.32% <ø> (-0.06%) ⬇️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.06% <ø> (-0.03%) ⬇️

@joshieDo joshieDo added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit bd28eed Aug 1, 2023
24 checks passed
@joshieDo joshieDo deleted the dan/add-storage-entry-docs branch August 1, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants