fix(primitives): nothing to prune situations for PruneModes
#4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshieDo
requested changes
Aug 1, 2023
| @@ -11,7 +11,7 @@ use serde::{Deserialize, Serialize}; | |||
| pub struct PruneModes { | |||
| /// Sender Recovery pruning configuration. | |||
| // TODO(alexey): removing min blocks restriction is possible if we start calculating the senders | |||
| // dynamically on blockchain tree unwind. | |||
| // dynamically on blockchain tree unwind. | |||
There was a problem hiding this comment.
Suggested change
| // dynamically on blockchain tree unwind. | |
| // dynamically on blockchain tree unwind. |
There was a problem hiding this comment.
istg this change makes sense for my ide (excuse my light theme)
joshieDo
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tip is less than the value in
PruneMode::DistanceorPruneMode::Before, there's nothing to prune yet and we should just returnNonefromprune_target_block_*methods. Previously, we were crashing with configuration error.