feat: add flag to CLI to disable colour coding of console output #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 125 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rakita
reviewed
Aug 2, 2023
bin/reth/src/cli/mod.rs
Outdated
|
|
||
| /// The flag to disable colour coding of console output. | ||
| #[arg(long = "log.not-coloured", global = true)] | ||
| not_coloured: bool, |
There was a problem hiding this comment.
@onbjerg you are better at naming things. Is this okay?
rakita
approved these changes
Aug 2, 2023
mattsse
added
M-changelog
onbjerg
changed the title
onbjerg
requested changes
Aug 9, 2023
mattsse
requested changes
Aug 10, 2023
onbjerg
approved these changes
Aug 14, 2023
alessandromazza98
added a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
…adigmxyz#4033) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4030
This PR adds a flag
--log.not-colouredto the CLI to disable the colour coding of console output.