feat(pipeline): prune receipts based on log emitters #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-staged-sync
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshieDo
requested review from
rakita,
onbjerg,
rkrasiuk,
shekhirin and
gakonst
as code owners
shekhirin
reviewed
Aug 3, 2023
mattsse
requested changes
Aug 4, 2023
Comment on lines
+20
to
+25
| pub fn prune_target_block( | ||
| &self, | ||
| tip: BlockNumber, | ||
| min_blocks: u64, | ||
| prune_part: PrunePart, | ||
| ) -> Result<Option<(BlockNumber, PruneMode)>, PrunePartError> { |
There was a problem hiding this comment.
can we add a sanity test for this, code looks correct afaict, just to be sure
shekhirin
approved these changes
Aug 4, 2023
|
testing on sepolia by including only receipts from the deposit contract and another random contract |
|
worked fine. receipt table ended the pipeline with ~15MB keeping all receipts from the last 128 blocks, and further only the ones (2 contracts) that were present in the configuration |
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to only include the deposit contract receipts, alongside whatever the user chooses to keep (ref #2753) . (for pipeline only)