Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: populate gas cost for vm instructions #4046

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: populate gas cost for vm instructions #4046

merged 2 commits into from
Aug 3, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 3, 2023

set the cost for vm instruction by fetching the Opcode info from the specid used for tracing

@mattsse mattsse added the A-rpc Related to the RPC implementation label Aug 3, 2023
@mattsse mattsse added the M-changelog This change should be included in the changelog label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #4046 (8ae9721) into main (0d33585) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.42% <0.00%> (+<0.01%) ⬆️
unit-tests 64.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.85% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.41% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 47.36% <ø> (ø)
networking 77.41% <ø> (-0.04%) ⬇️
rpc 57.85% <ø> (-0.01%) ⬇️
consensus 64.03% <ø> (ø)
revm 32.59% <0.00%> (-0.09%) ⬇️
payload builder 6.58% <ø> (ø)
primitives 87.98% <ø> (-0.04%) ⬇️

@mattsse mattsse enabled auto-merge August 3, 2023 18:17
@mattsse mattsse added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 6ceaad6 Aug 3, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-gas-cost branch August 3, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @joshieDo