Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(engine): downgrade new payload buffering log to debug #4068

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

shekhirin
Copy link
Collaborator

Resolves #4057

Otherwise we're spamming warnings when long-running pruning is active. We still need to emit warnings on missed FCUs though, as it's more critical and need to be acted on immediately.

@mattsse mattsse enabled auto-merge August 4, 2023 15:36
@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Aug 4, 2023
@shekhirin shekhirin added A-pruning Related to pruning or full node and removed A-pruning Related to pruning or full node labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4068 (2b7b329) into main (ff1ef29) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 75.70% <0.00%> (ø)

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.46% <0.00%> (-0.01%) ⬇️
unit-tests 64.10% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.64% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.41% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 48.29% <ø> (+0.59%) ⬆️
networking 77.41% <ø> (-0.01%) ⬇️
rpc 57.85% <ø> (ø)
consensus 64.03% <0.00%> (ø)
revm 32.59% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 87.99% <ø> (-0.03%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit 64188a3 Aug 4, 2023
24 checks passed
@mattsse mattsse deleted the alexey/engine-new-payload-pruner-active branch August 4, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade newPayload buffering logs from warning to debug when pruning is in progress
3 participants