Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record push stack as vec u256 #4077

Merged
merged 2 commits into from
Aug 7, 2023
Merged

fix: record push stack as vec u256 #4077

merged 2 commits into from
Aug 7, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 5, 2023

ref #4071

there can be multiple new stack values (PUSH_X).

change type from H256 -> U256 in rpc type, and record as vec

@mattsse mattsse requested a review from Rjected as a code owner August 5, 2023 12:34
@mattsse mattsse added C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #4077 (891dd3f) into main (9569deb) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <ø> (ø)
crates/rpc/rpc-types/src/eth/trace/parity.rs 66.31% <ø> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.55% <0.00%> (-0.02%) ⬇️
unit-tests 64.00% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.52% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.59% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 48.24% <ø> (ø)
networking 77.40% <ø> (-0.05%) ⬇️
rpc 57.43% <ø> (-0.03%) ⬇️
consensus 63.97% <ø> (ø)
revm 32.53% <0.00%> (-0.01%) ⬇️
payload builder 6.57% <ø> (ø)
primitives 88.02% <ø> (-0.03%) ⬇️

@mattsse mattsse requested a review from rkrasiuk August 5, 2023 15:05
@mattsse mattsse enabled auto-merge August 5, 2023 16:30
@mattsse mattsse added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit 64c8dd2 Aug 7, 2023
24 checks passed
@mattsse mattsse deleted the matt/push-stack branch August 7, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants