Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ext fns mut #4081

Merged
merged 3 commits into from
Aug 5, 2023
Merged

chore: make ext fns mut #4081

merged 3 commits into from
Aug 5, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 5, 2023

additional docs and make ext functions mut

@mattsse mattsse requested a review from onbjerg as a code owner August 5, 2023 14:50
@mattsse mattsse added the A-cli Related to the reth CLI label Aug 5, 2023
@mattsse mattsse requested a review from rkrasiuk August 5, 2023 14:50
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending doc fixes

@mattsse mattsse requested a review from gakonst as a code owner August 5, 2023 14:57
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #4081 (9bb2e47) into main (c0abfce) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/rpc_server_args.rs 53.98% <0.00%> (ø)
bin/reth/src/cli/ext.rs 1.78% <0.00%> (ø)
bin/reth/src/node/mod.rs 12.50% <0.00%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.54% <0.00%> (+<0.01%) ⬆️
unit-tests 64.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.67% <0.00%> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.41% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 48.36% <ø> (ø)
networking 77.43% <ø> (ø)
rpc 57.87% <ø> (-0.01%) ⬇️
consensus 64.08% <ø> (ø)
revm 32.59% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.01% <ø> (+0.02%) ⬆️

@mattsse mattsse enabled auto-merge August 5, 2023 15:10
@mattsse mattsse added this pull request to the merge queue Aug 5, 2023
Merged via the queue into main with commit 3aff8de Aug 5, 2023
24 checks passed
@mattsse mattsse deleted the matt/make-ext-mut branch August 5, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants