feat: re-export c-kzg types and impl rlp traits
#4084
Conversation
Rjected
added
C-enhancement
Codecov Report
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
crates/rlp/Cargo.toml
Outdated
| # for eip-4844 | ||
| c-kzg = { git = "https://github.com/ethereum/c-kzg-4844", optional = true } |
There was a problem hiding this comment.
@DaniPopes wdyt here, how would this affect migration to alloy-rlp?
There was a problem hiding this comment.
Looks like it's just wrappers for byte arrays so it should be fine, but in general i don't think it's the rlp's crate job to provide implementations for external types
There was a problem hiding this comment.
the only other feasible solution would be to use wrapper types in reth which I think is messier
we could try to add it to the c-kzg repo itself eventually
crates/primitives/Cargo.toml
Outdated
| # for eip-4844 | ||
| c-kzg = { git = "https://github.com/ethereum/c-kzg-4844" } |
There was a problem hiding this comment.
let's move to workspace dep
This re-exports the
c-kzgcrate inreth-primitivesin thekzgmodule, also implementingEncodableandDecodable