standalone rpc_types

[supernovahs]

Ref #3964

[supernovahs]

Will now figure out how to delete the duplicate code from https://github.com/paradigmxyz/reth/blob/c423514321c2d2e67a156681d5602cb1707852e3/crates/rpc/rpc-types/src/eth/transaction/mod.rs

[codecov]

Codecov Report

Merging #4088 (64062fb) into main (b823cc0) will decrease coverage by 54.48%.
Report is 1 commits behind head on main.
The diff coverage is 1.08%.

Files Changed	Coverage Δ
crates/rpc/rpc-types-compat/src/block.rs	0.00% <0.00%> (ø)
crates/rpc/rpc-types-compat/src/transaction/mod.rs	0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/block.rs	0.00% <ø> (-39.85%)	⬇️
crates/rpc/rpc-types/src/eth/transaction/mod.rs	0.00% <ø> (-42.08%)	⬇️
crates/rpc/rpc/src/eth/api/transactions.rs	16.26% <0.00%> (-15.15%)	⬇️
crates/rpc/rpc/src/eth/pubsub.rs	6.66% <0.00%> (ø)
crates/rpc/rpc/src/txpool.rs	0.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/block.rs	50.94% <66.66%> (-0.44%)	⬇️

... and 391 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	14.21% <1.08%> (-2.70%)	⬇️
unit-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	5.48% <ø> (-19.90%)	⬇️
blockchain tree	0.00% <ø> (-83.05%)	⬇️
pipeline	0.00% <ø> (-90.08%)	⬇️
storage (db)	16.48% <ø> (-58.15%)	⬇️
trie	0.00% <ø> (-94.72%)	⬇️
txpool	20.94% <ø> (-26.65%)	⬇️
networking	20.16% <ø> (-57.21%)	⬇️
rpc	23.81% <1.08%> (-34.87%)	⬇️
consensus	0.98% <ø> (-62.78%)	⬇️
revm	0.94% <ø> (-31.33%)	⬇️
payload builder	6.57% <ø> (ø)
primitives	19.09% <ø> (-68.70%)	⬇️

[mattsse]

perhaps there was a misunderstanding,

all type defs should remain in rpc-types crate, and we only want to extract all the functions

right @DaniPopes ?

[mattsse]

I would prefer something other than util

[supernovahs]

ok

[mattsse]

I think compat or convert are better alternatives

[supernovahs]

Don't know why I am getting cyclic dependency errors on cargo test

error: cyclic package dependency: package `reth-rpc-types v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/rpc/rpc-types)` depends on itself. Cycle:
package `reth-rpc-types v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/rpc/rpc-types)`
    ... which satisfies path dependency `reth-rpc-types` of package `reth-rpc-types-compat v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/rpc/rpc-types-compat)`
    ... which satisfies path dependency `reth-rpc-types-compat` of package `reth-rpc-types v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/rpc/rpc-types)`
    ... which satisfies path dependency `reth-rpc-types` of package `reth-network-api v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/net/network-api)`
    ... which satisfies path dependency `reth-network-api` of package `reth-interfaces v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/interfaces)`
    ... which satisfies path dependency `reth-interfaces` of package `reth-consensus-common v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/consensus/common)`
    ... which satisfies path dependency `reth-consensus-common` of package `reth-beacon-consensus v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/consensus/beacon)`
    ... which satisfies path dependency `reth-beacon-consensus` of package `reth-auto-seal-consensus v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/crates/consensus/auto-seal)`
    ... which satisfies path dependency `reth-auto-seal-consensus` of package `reth v0.1.0-alpha.4 (/Users/supernovahs/Desktop/reth/bin/reth)`
    ... which satisfies path dependency `reth` of package `additional-rpc-namespace-in-cli v0.0.0 (/Users/supernovahs/Desktop/reth/examples/additional-rpc-namespace-in-cli)`

[supernovahs]

Got it, I would have to separate every function , such that rpc_types does not import compat in any case

[supernovahs]

I have made the changes. But +nightly fmt could not be done, due to some issues with my mac .
Ty

[mattsse]

amazing, this looks great, ty!

I'll take care of the fmt issue