Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not propagate full 4844 transactions #4105

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 8, 2023

This checks the transaction type, and does not propagate the transaction if it is an EIP-4844 transaction. This implements the following part of the EIP-4844 spec:

Nodes MUST NOT automatically broadcast blob transactions to their peers. Instead, those transactions are only announced using NewPooledTransactionHashes messages, and can then be manually requested via GetPooledTransactions.

@Rjected Rjected added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-networking Related to networking in general M-eip This change relates to the implementation of an EIP E-cancun Related to the Cancun network upgrade labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4105 (57242da) into main (40230e7) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/network/src/transactions.rs 49.66% <0.00%> (-1.21%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.49% <0.00%> (-0.02%) ⬇️
unit-tests 63.99% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.52% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.59% <ø> (+<0.01%) ⬆️
trie 94.67% <ø> (-0.04%) ⬇️
txpool 48.16% <ø> (-0.03%) ⬇️
networking 77.53% <0.00%> (+0.10%) ⬆️
rpc 57.48% <ø> (ø)
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.78% <ø> (ø)

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/net/network/src/transactions.rs Outdated Show resolved Hide resolved
@mattsse mattsse enabled auto-merge August 8, 2023 09:06
@mattsse mattsse added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 62f39a5 Aug 8, 2023
25 checks passed
@mattsse mattsse deleted the dan/do-not-propagate-eip-4844 branch August 8, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general A-tx-pool Related to the transaction mempool C-enhancement New feature or request E-cancun Related to the Cancun network upgrade M-eip This change relates to the implementation of an EIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants