Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unused deps sanity check #4106

Merged
merged 1 commit into from
Aug 8, 2023
Merged

chore: unused deps sanity check #4106

merged 1 commit into from
Aug 8, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 8, 2023

Fixed unused deps sanity check by removing constants::self

🤖 Generated by Copilot at daaa2e1

Reformatted server.rs to remove unused import and follow style guidelines.

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation C-test A change that impacts how or what we test labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4106 (5cc5a45) into main (40230e7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/api/server.rs 91.93% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.52% <ø> (+<0.01%) ⬆️
unit-tests 63.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.52% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.59% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 48.16% <ø> (-0.03%) ⬇️
networking 77.43% <ø> (+<0.01%) ⬆️
rpc 57.48% <ø> (+<0.01%) ⬆️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.78% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 759eaf5 Aug 8, 2023
25 checks passed
@mattsse mattsse deleted the dan/fix-dep-sanity-check branch August 8, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants