feat: adds arbitratry to BlobTransaction and KZG_TRUSTED_SETUP
#4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
A-networking
joshieDo
commented
Aug 8, 2023
| type Parameters = ParamsFor<String>; | ||
| fn arbitrary_with(_args: Self::Parameters) -> Self::Strategy { | ||
| ( | ||
| proptest_vec(proptest_vec(proptest_any::<u8>(), BYTES_PER_BLOB), 1..=5), |
There was a problem hiding this comment.
using proptest_any::<[u8; BYTES_PER_BLOB]>() instead of proptest_vec(proptest_any::<u8>(), BYTES_PER_BLOB) causes proptest to hit:
thread 'types::transactions::BlobTransactionTests::proptest' has overflowed its stack
There was a problem hiding this comment.
interesting, BYTES_PER_BLOB is pretty large, so i wonder if that's partially why
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rjected
approved these changes
Aug 9, 2023
mattsse
approved these changes
Aug 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #4102 (created the PR pointing there for easier diff view)
arbitraryand rlp proptest tests toBlobTransactionKZG_TRUSTED_SETUP. Wdyt