Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trie): include destroyed accounts in account prefix set #4126

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(trie): include destroyed accounts in account prefix set #4126

merged 1 commit into from
Aug 9, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Aug 9, 2023

Description

Oversight in #4108 introduced a bug where the destroyed accounts were no longer included in the general account prefix set.

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Aug 9, 2023
@rkrasiuk rkrasiuk requested a review from mattsse August 9, 2023 11:15
@rkrasiuk rkrasiuk enabled auto-merge August 9, 2023 11:23
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #4126 (7375902) into main (b823cc0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
...torage/provider/src/providers/database/provider.rs 79.64% <100.00%> (+0.05%) ⬆️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.90% <0.00%> (-0.01%) ⬇️
unit-tests 63.89% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.38% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.63% <100.00%> (+<0.01%) ⬆️
trie 94.71% <ø> (ø)
txpool 47.59% <ø> (ø)
networking 77.35% <ø> (-0.02%) ⬇️
rpc 58.66% <ø> (-0.02%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.78% <ø> (ø)

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 058c55c Aug 9, 2023
25 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/fix-provider-account-prefixset branch August 9, 2023 11:34
@mattsse mattsse mentioned this pull request Aug 9, 2023
Closed
1 task
@rkrasiuk rkrasiuk mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse