Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hit database first for lookups #4127

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 9, 2023

looking up data in the tree can be blocked by engine atm (RWlock around tree)

this swaps the lookup order, so tree is fallback instead of the first attempt

ref #4064

@mattsse mattsse requested a review from rkrasiuk August 9, 2023 11:57
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #4127 (5cea345) into main (058c55c) will decrease coverage by 0.02%.
The diff coverage is 28.57%.

Impacted file tree graph

Files Changed Coverage Δ
crates/storage/provider/src/providers/mod.rs 16.16% <28.57%> (-0.18%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.90% <0.00%> (-0.02%) ⬇️
unit-tests 63.92% <28.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.38% <ø> (ø)
blockchain tree 82.83% <ø> (-0.22%) ⬇️
pipeline 90.07% <ø> (ø)
storage (db) 74.59% <28.57%> (-0.04%) ⬇️
trie 94.67% <ø> (-0.05%) ⬇️
txpool 48.16% <ø> (-0.03%) ⬇️
networking 77.39% <ø> (-0.02%) ⬇️
rpc 58.67% <ø> (-0.03%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.78% <ø> (+0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 7ea381f Aug 9, 2023
24 checks passed
@mattsse mattsse deleted the matt/perf-swap-lookup-order branch August 9, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants