Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove cargo deny rule for c-kzg #4133

Merged
merged 1 commit into from
Aug 9, 2023
Merged

chore: remove cargo deny rule for c-kzg #4133

merged 1 commit into from
Aug 9, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 9, 2023

Now that ethereum/c-kzg-4844#328 is merged, we can remove the cargo deny clarify rule

@Rjected Rjected added C-debt Refactor of code section that is hard to understand or maintain A-utils Related to commonly used utilities labels Aug 9, 2023
@Rjected Rjected requested a review from gakonst as a code owner August 9, 2023 20:54
@mattsse mattsse added this pull request to the merge queue Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #4133 (2e0a605) into main (e925cbc) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

see 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.86% <ø> (-0.02%) ⬇️
unit-tests 64.06% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.72% <ø> (ø)
trie 94.71% <ø> (+0.04%) ⬆️
txpool 47.66% <ø> (ø)
networking 77.73% <ø> (+0.01%) ⬆️
rpc 58.70% <ø> (+0.02%) ⬆️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.88% <ø> (-0.03%) ⬇️

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 9, 2023
@Rjected Rjected added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 24def95 Aug 9, 2023
25 checks passed
@Rjected Rjected deleted the dan/remove-cargo-deny branch August 9, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-utils Related to commonly used utilities C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse